Skip to content

refactor: remove parameter reassignment #10715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sdanialraza
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Reassigner, no reassigning

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Copy link

vercel bot commented Jan 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 3:14pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 3:14pm

@sdanialraza sdanialraza force-pushed the refactor/reassigner-no-reassigning branch 3 times, most recently from c328b8d to 78b95fa Compare January 25, 2025 20:45
@sdanialraza sdanialraza marked this pull request as ready for review January 25, 2025 20:50
@sdanialraza sdanialraza requested a review from a team as a code owner January 25, 2025 20:50
@sdanialraza sdanialraza force-pushed the refactor/reassigner-no-reassigning branch from 78b95fa to 15ca9da Compare January 31, 2025 17:52
@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Feb 4, 2025
almeidx
almeidx previously requested changes Feb 4, 2025
sdanialraza and others added 2 commits February 15, 2025 13:32
@sdanialraza sdanialraza force-pushed the refactor/reassigner-no-reassigning branch from 5ac14fc to ce0438f Compare February 15, 2025 12:32
Co-authored-by: Qjuh <Qjuh@users.noreply.github.com>
@sdanialraza sdanialraza requested a review from Qjuh February 16, 2025 01:23
Qjuh
Qjuh previously requested changes Feb 16, 2025
Co-authored-by: Almeida <github@almeidx.dev>
@kodiakhq kodiakhq bot merged commit b6fda78 into discordjs:main Feb 26, 2025
7 checks passed
@sdanialraza sdanialraza deleted the refactor/reassigner-no-reassigning branch February 26, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Switch code patterns to go from mutating options, to keeping them read only
7 participants